Commit 509b97fd authored by Tomáš Golembiovský's avatar Tomáš Golembiovský Committed by Michael Roth
Browse files

test-qga: add trivial tests for some commands 



These commands did not get their tests in the original commits:
- guest-get-host-name
- guest-get-timezone
- guest-get-users

Trivial tests that mostly only call the commands were added.

Signed-off-by: default avatarTomáš Golembiovský <tgolembi@redhat.com>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
* replace QDECREF() with qobject_unref()
Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent c07e5e6e

tests/test-qga.c

+54 −0
Original line number Diff line number Diff line
@@ -854,6 +854,54 @@ static void test_qga_guest_exec_invalid(gconstpointer fix) 
    qobject_unref(ret);

}



static void test_qga_guest_get_host_name(gconstpointer fix)

{

    const TestFixture *fixture = fix;

    QDict *ret, *val;



    ret = qmp_fd(fixture->fd, "{'execute': 'guest-get-host-name'}");

    g_assert_nonnull(ret);

    qmp_assert_no_error(ret);



    val = qdict_get_qdict(ret, "return");

    g_assert(qdict_haskey(val, "host-name"));



    qobject_unref(ret);

}



static void test_qga_guest_get_timezone(gconstpointer fix)

{

    const TestFixture *fixture = fix;

    QDict *ret, *val;



    ret = qmp_fd(fixture->fd, "{'execute': 'guest-get-timezone'}");

    g_assert_nonnull(ret);

    qmp_assert_no_error(ret);



    /* Make sure there's at least offset */

    val = qdict_get_qdict(ret, "return");

    g_assert(qdict_haskey(val, "offset"));



    qobject_unref(ret);

}



static void test_qga_guest_get_users(gconstpointer fix)

{

    const TestFixture *fixture = fix;

    QDict *ret;

    QList *val;



    ret = qmp_fd(fixture->fd, "{'execute': 'guest-get-users'}");

    g_assert_nonnull(ret);

    qmp_assert_no_error(ret);



    /* There is not much to test here */

    val = qdict_get_qlist(ret, "return");

    g_assert_nonnull(val);



    qobject_unref(ret);

}



static void test_qga_guest_get_osinfo(gconstpointer data)

{

    TestFixture fixture;
@@ -946,6 +994,12 @@ int main(int argc, char **argv) 
                         test_qga_guest_exec_invalid);

    g_test_add_data_func("/qga/guest-get-osinfo", &fix,

                         test_qga_guest_get_osinfo);

    g_test_add_data_func("/qga/guest-get-host-name", &fix,

                         test_qga_guest_get_host_name);

    g_test_add_data_func("/qga/guest-get-timezone", &fix,

                         test_qga_guest_get_timezone);

    g_test_add_data_func("/qga/guest-get-users", &fix,

                         test_qga_guest_get_users);



    ret = g_test_run();