Commit 4fd6a984 authored by Prasad Joshi's avatar Prasad Joshi Committed by Stefan Hajnoczi
Browse files

qemu-img: mandate argument to 'qemu-img check --repair' 



qemu-img check --repair option accepts an argument. The argument to
--repair switch can either be 'all' or 'leak'. Fix the long option to
mandate argument with --repair switch.

The patch fixes following segmentation fault

Core was generated by `qemu-img check -f qcow2 --repair all t.qcow2'.
Program terminated with signal 11, Segmentation fault.
0  in img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588
588	            if (!strcmp(optarg, "leaks")) {
(gdb) bt
  0  img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588
  1  __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6
  2  _start ()
(gdb)

Signed-off-by: default avatarPrasad Joshi <prasadjoshi.linux@gmail.com>
Reviewed-by: default avatarLeandro Dorileo <l@dorileo.org>
Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent ae2990c2

qemu-img.c

+1 −1
Original line number Diff line number Diff line
@@ -565,7 +565,7 @@ static int img_check(int argc, char **argv) 
        static const struct option long_options[] = {

            {"help", no_argument, 0, 'h'},

            {"format", required_argument, 0, 'f'},

            {"repair", no_argument, 0, 'r'},

            {"repair", required_argument, 0, 'r'},

            {"output", required_argument, 0, OPTION_OUTPUT},

            {0, 0, 0, 0}

        };