Commit 4fc4c6a5 authored by Greg Kurz's avatar Greg Kurz Committed by David Gibson
Browse files

spapr_pci: convert g_malloc() to g_new() 



When allocating an array, it is a recommended coding practice to call
g_new(FooType, n) instead of g_malloc(n * sizeof(FooType)) because
it takes care to avoid overflow when calculating the size of the
allocated block and it returns FooType *, which allows the compiler
to perform type checking.

Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent a3dec427

hw/ppc/spapr_pci.c

+1 −1
Original line number Diff line number Diff line
@@ -1882,7 +1882,7 @@ static int spapr_pci_pre_save(void *opaque) 
    if (!sphb->msi_devs_num) {

        return 0;

    }

    sphb->msi_devs = g_malloc(sphb->msi_devs_num * sizeof(spapr_pci_msi_mig));

    sphb->msi_devs = g_new(spapr_pci_msi_mig, sphb->msi_devs_num);



    g_hash_table_iter_init(&iter, sphb->msi);

    for (i = 0; g_hash_table_iter_next(&iter, &key, &value); ++i) {