Commit 4f8e3a1f authored by Fam Zheng's avatar Fam Zheng Committed by Kevin Wolf
Browse files

vvfat: Fix inherit_options flags 



Overriding flags violates the precedence rules of
bdrv_reopen_queue_child. Just like the read-only option, no-flush should
be put into the options. The same is done in bdrv_temp_snapshot_options.

Reported-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent b76e4458

block/vvfat.c

+1 −1
Original line number Diff line number Diff line
@@ -3129,7 +3129,7 @@ static void vvfat_qcow_options(int *child_flags, QDict *child_options, 
                               int parent_flags, QDict *parent_options)

{

    qdict_set_default_str(child_options, BDRV_OPT_READ_ONLY, "off");

    *child_flags = BDRV_O_NO_FLUSH;

    qdict_set_default_str(child_options, BDRV_OPT_CACHE_NO_FLUSH, "on");

}



static const BdrvChildRole child_vvfat_qcow = {