Commit 4f293bd6 authored by Wendy Liang's avatar Wendy Liang Committed by Edgar E. Iglesias
Browse files

xilinx_axidma: Do not set DMA .notify to NULL after notify 



If a stream notify function is not ready, it may re-populate the notify call-
back to indicate it should be re-polled later. This break in this usage, as
immediately following the notify() call, .notify is set to NULL. reverse the
ordering of the notify call and NULL assignment accordingly.

[PC: Reworked commit message]

Signed-off-by: default avatarWendy Liang <jliang@xilinx.com>
Signed-off-by: default avatarPeter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: default avatarEdgar E. Iglesias <edgar.iglesias@gmail.com>
parent 4e298e46

hw/dma/xilinx_axidma.c

+2 −1
Original line number Diff line number Diff line
@@ -514,8 +514,9 @@ static void axidma_write(void *opaque, hwaddr addr, 
            break;

    }

    if (sid == 1 && d->notify) {

        d->notify(d->notify_opaque);

        StreamCanPushNotifyFn notifytmp = d->notify;

        d->notify = NULL;

        notifytmp(d->notify_opaque);

    }

    stream_update_irq(s);

}