Commit 4f04560b authored by Peter Maydell's avatar Peter Maydell Committed by Michael Tokarev
Browse files

scsi-disk: add 'fall through' comment to switch VERIFY cases 



Commit 166dbda7 added some extra cases to a switch() such
that the existing code is intended to fall through the new
case statements. It's clear from the commit that this is
intentional, but less clear to subsequent readers of the
code, and not clear at all to static analysis tools like
Coverity. Add a /* fall through */ comment to indicate the
intent. (Fixes CID 1368287.)

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent 87eb2bac

hw/scsi/scsi-disk.c

+1 −0
Original line number Diff line number Diff line
@@ -2157,6 +2157,7 @@ static int32_t scsi_disk_dma_command(SCSIRequest *req, uint8_t *buf) 
        DPRINTF("Write %s(sector %" PRId64 ", count %u)\n",

                (command & 0xe) == 0xe ? "And Verify " : "",

                r->req.cmd.lba, len);

        /* fall through */

    case VERIFY_10:

    case VERIFY_12:

    case VERIFY_16: