Commit 4f01a637 authored by David Gibson's avatar David Gibson Committed by Eduardo Habkost
Browse files

sysbus: Remove ignored return value of FindSysbusDeviceFunc 



Functions of type FindSysbusDeviceFunc currently return an integer.
However, this return value is always ignored by the caller in
find_sysbus_device().

This changes the function type to return void, to avoid confusion over
the function semantics.

Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 55c911a5

hw/arm/sysbus-fdt.c

+2 −2
Original line number Diff line number Diff line
@@ -436,7 +436,7 @@ static const NodeCreationPair add_fdt_node_functions[] = { 
 * are dynamically instantiable and if so call the node creation

 * function.

 */

static int add_fdt_node(SysBusDevice *sbdev, void *opaque)

static void add_fdt_node(SysBusDevice *sbdev, void *opaque)

{

    int i, ret;
@@ -445,7 +445,7 @@ static int add_fdt_node(SysBusDevice *sbdev, void *opaque) 
                    add_fdt_node_functions[i].typename)) {

            ret = add_fdt_node_functions[i].add_fdt_node_fn(sbdev, opaque);

            assert(!ret);

            return 0;

            return;

        }

    }

    error_report("Device %s can not be dynamically instantiated",

hw/core/machine.c

+1 −1
Original line number Diff line number Diff line
@@ -332,7 +332,7 @@ static bool machine_get_enforce_config_section(Object *obj, Error **errp) 
    return ms->enforce_config_section;

}



static int error_on_sysbus_device(SysBusDevice *sbdev, void *opaque)

static void error_on_sysbus_device(SysBusDevice *sbdev, void *opaque)

{

    error_report("Option '-device %s' cannot be handled by this machine",

                 object_class_get_name(object_get_class(OBJECT(sbdev))));

hw/core/platform-bus.c

+2 −6
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ hwaddr platform_bus_get_mmio_addr(PlatformBusDevice *pbus, SysBusDevice *sbdev, 
    return object_property_get_int(OBJECT(sbdev_mr), "addr", NULL);

}



static int platform_bus_count_irqs(SysBusDevice *sbdev, void *opaque)

static void platform_bus_count_irqs(SysBusDevice *sbdev, void *opaque)

{

    PlatformBusDevice *pbus = opaque;

    qemu_irq sbirq;
@@ -93,8 +93,6 @@ static int platform_bus_count_irqs(SysBusDevice *sbdev, void *opaque) 
            }

        }

    }



    return 0;

}



/*
@@ -168,7 +166,7 @@ static void platform_bus_map_mmio(PlatformBusDevice *pbus, SysBusDevice *sbdev, 
 * For each sysbus device, look for unassigned IRQ lines as well as

 * unassociated MMIO regions. Connect them to the platform bus if available.

 */

static int link_sysbus_device(SysBusDevice *sbdev, void *opaque)

static void link_sysbus_device(SysBusDevice *sbdev, void *opaque)

{

    PlatformBusDevice *pbus = opaque;

    int i;
@@ -180,8 +178,6 @@ static int link_sysbus_device(SysBusDevice *sbdev, void *opaque) 
    for (i = 0; sysbus_has_mmio(sbdev, i); i++) {

        platform_bus_map_mmio(pbus, sbdev, i);

    }



    return 0;

}



static void platform_bus_init_notify(Notifier *notifier, void *data)

hw/ppc/e500.c

+1 −3
Original line number Diff line number Diff line
@@ -196,7 +196,7 @@ static int create_devtree_etsec(SysBusDevice *sbdev, PlatformDevtreeData *data) 
    return 0;

}



static int sysbus_device_create_devtree(SysBusDevice *sbdev, void *opaque)

static void sysbus_device_create_devtree(SysBusDevice *sbdev, void *opaque)

{

    PlatformDevtreeData *data = opaque;

    bool matched = false;
@@ -211,8 +211,6 @@ static int sysbus_device_create_devtree(SysBusDevice *sbdev, void *opaque) 
                     qdev_fw_name(DEVICE(sbdev)));

        exit(1);

    }



    return 0;

}



static void platform_bus_create_devtree(PPCE500Params *params, void *fdt,

hw/ppc/spapr.c

+1 −3
Original line number Diff line number Diff line
@@ -1110,7 +1110,7 @@ static void spapr_reallocate_hpt(sPAPRMachineState *spapr, int shift, 
    }

}



static int find_unknown_sysbus_device(SysBusDevice *sbdev, void *opaque)

static void find_unknown_sysbus_device(SysBusDevice *sbdev, void *opaque)

{

    bool matched = false;
@@ -1123,8 +1123,6 @@ static int find_unknown_sysbus_device(SysBusDevice *sbdev, void *opaque) 
                     qdev_fw_name(DEVICE(sbdev)));

        exit(1);

    }



    return 0;

}



static void ppc_spapr_reset(void)