Commit 4e8de606 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Laurent Vivier
Browse files

vl: Rewrite a fall through comment 



GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

  vl.c: In function ‘qemu_ref_timedate’:
  vl.c:773:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
    773 |         value -= rtc_realtime_clock_offset;
        |         ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  vl.c:775:5: note: here
    775 |     case QEMU_CLOCK_VIRTUAL:
        |     ^~~~
  cc1: all warnings being treated as errors

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: default avatarStefan Weil <sw@weilnetz.de>
Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarJohn Snow <jsnow@redhat.com>
Message-Id: <20190719131425.10835-7-philmd@redhat.com>
Signed-off-by: default avatarLaurent Vivier <laurent@vivier.eu>
parent b1d5b6e5

vl.c

+1 −1
Original line number Diff line number Diff line
@@ -772,7 +772,7 @@ static time_t qemu_ref_timedate(QEMUClockType clock) 
    switch (clock) {

    case QEMU_CLOCK_REALTIME:

        value -= rtc_realtime_clock_offset;

        /* no break */

        /* fall through */

    case QEMU_CLOCK_VIRTUAL:

        value += rtc_ref_start_datetime;

        break;