Commit 4dabe747 authored by Jan Kiszka's avatar Jan Kiszka Committed by Peter Maydell
Browse files

gdbstub: Introduce an is is_query_packet helper 



This helper supports parsing of query packets with optional extensions.
The separator can be specified so that we can use it already for both
qqemu.sstep[=] and qSupported[:feature].

Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 070949f3

gdbstub.c

+10 −2
Original line number Diff line number Diff line
@@ -769,6 +769,14 @@ static CPUState *find_cpu(uint32_t thread_id) 
    return NULL;

}



static int is_query_packet(const char *p, const char *query, char separator)

{

    unsigned int query_len = strlen(query);



    return strncmp(p, query, query_len) == 0 &&

        (p[query_len] == '\0' || p[query_len] == separator);

}



static int gdb_handle_packet(GDBState *s, const char *line_buf)

{

    CPUState *cpu;
@@ -1062,7 +1070,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) 
                     SSTEP_NOTIMER);

            put_packet(s, buf);

            break;

        } else if (strncmp(p,"qemu.sstep",10) == 0) {

        } else if (is_query_packet(p, "qemu.sstep", '=')) {

            /* Display or change the sstep_flags */

            p += 10;

            if (*p != '=') {
@@ -1135,7 +1143,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) 
            break;

        }

#endif /* !CONFIG_USER_ONLY */

        if (strncmp(p, "Supported", 9) == 0) {

        if (is_query_packet(p, "Supported", ':')) {

            snprintf(buf, sizeof(buf), "PacketSize=%x", MAX_PACKET_LENGTH);

            cc = CPU_GET_CLASS(first_cpu);

            if (cc->gdb_core_xml_file != NULL) {