Commit 4d9ab7d4 authored by Greg Kurz's avatar Greg Kurz Committed by Alexander Graf
Browse files

spapr_iommu: drop erroneous check in h_put_tce_indirect() 



The tce_list variable is not a TCE but the address to a TCE: we shouldn't
clear permission bits as we do now. And this is dead code anyway since we
check tce_list is 4K aligned a few lines above.

This patch doesn't fix any bug, it is only code cleanup.

Suggested-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: default avatarGreg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
parent 9b7d9284

hw/ppc/spapr_iommu.c

+1 −3
Original line number Diff line number Diff line
@@ -267,9 +267,7 @@ static target_ulong h_put_tce_indirect(PowerPCCPU *cpu, 
    ioba &= page_mask;



    for (i = 0; i < npages; ++i, ioba += page_size) {

        target_ulong off = (tce_list & ~SPAPR_TCE_RW) +

                                i * sizeof(target_ulong);

        tce = ldq_be_phys(cs->as, off);

        tce = ldq_be_phys(cs->as, tce_list + i * sizeof(target_ulong));



        ret = put_tce_emu(tcet, ioba, tce);

        if (ret) {