Commit 4c0542ea authored by Fam Zheng's avatar Fam Zheng Committed by Kevin Wolf
Browse files

virtio-blk: Remove the stale FIXME comment 



By default, we have ioeventfd enabled, so the IO request processing is
in IO thread; in the vcpu thread, guest mode is returned to as quickly
as possible, and completion is delivered via irqfd. Therefore this
comment from the initial implementation is barely relevant.

Signed-off-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 9b7d2d8b

hw/block/virtio-blk.c

+0 −6
Original line number Diff line number Diff line
@@ -597,12 +597,6 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq) 
    if (mrb.num_reqs) {

        virtio_blk_submit_multireq(s->blk, &mrb);

    }



    /*

     * FIXME: Want to check for completions before returning to guest mode,

     * so cached reads and writes are reported as quickly as possible. But

     * that should be done in the generic block layer.

     */

}



static void virtio_blk_dma_restart_bh(void *opaque)