Commit 4bc02e23 authored Aug 12, 2014 by Tom Musta Committed by Alexander Graf Sep 08, 2014

target-ppc: Bug Fix: srad



Fix the check for carry in the srad helper to properly construct
the mask -- a "1ULL" must be used (instead of "1") in order to
get the desired result.

Example:

R3 8000000000000000
R4 F3511AD4A2CD4C38
srad 3,3,4

Should *not* set XER[CA] but does without this patch.

Signed-off-by: Tom Musta <tommusta@gmail.com>
Signed-off-by: Alexander Graf <agraf@suse.de>

parent 34a0fad1

target-ppc/int_helper.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -248,7 +248,7 @@ target_ulong helper_srad(CPUPPCState *env, target_ulong value,
		if (likely((uint64_t)shift != 0)) {
		shift &= 0x3f;
		ret = (int64_t)value >> shift;
		if (likely(ret >= 0 \|\| (value & ((1 << shift) - 1)) == 0)) {
		if (likely(ret >= 0 \|\| (value & ((1ULL << shift) - 1)) == 0)) {
		env->ca = 0;
		} else {
		env->ca = 1;