Commit 4b5660e4 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Michael Tokarev
Browse files

m68k/translate: fix incorrect copy/paste 



db3d7945 extended gen_cc_cond() for cond [6, 7, 9, 10] but misswrote [4, 5]

target/m68k/translate.c:1323:70: warning: identical expressions on both sides of logical operator
        if (op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL ||
            op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL) {
            ~~~~~~~~~~~~~~~~    ~~~~~~~~~~~~~~~~    ~~~~~~~~~~~~~~~~ ^

Reported-by: Clang Static Analyzer
Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: default avatarLaurent Vivier <laurent@vivier.eu>
Reviewed-by: default avatarRichard Henderson <rth@twiddle.net>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent b2caa3b8

target/m68k/translate.c

+1 −1
Original line number Diff line number Diff line
@@ -1321,7 +1321,7 @@ static void gen_cc_cond(DisasCompare *c, DisasContext *s, int cond) 
    case 5: /* CS (C) */

        /* Some cases fold C into X.  */

        if (op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL ||

            op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL) {

            op == CC_OP_SUBB || op == CC_OP_SUBW || op == CC_OP_SUBL) {

            tcond = TCG_COND_NE;

            c->v1 = QREG_CC_X;

            goto done;