Commit 4add0da6 authored by Halil Pasic's avatar Halil Pasic Committed by Cornelia Huck
Browse files

s390x/css: fix bits must be zero check for TIC 



According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must
contain zeros.  Bits 0-3 are already covered by cmd_code validity
checking, and bit 32 is covered by the CCW address checking.

Bits 8-31 correspond to CCW1.flags and CCW1.count.  Currently we only
check for the absence of certain flags.  Let's fix this.

Signed-off-by: default avatarHalil Pasic <pasic@linux.vnet.ibm.com>
Message-Id: <20170725224442.13383-3-pasic@linux.vnet.ibm.com>
Reviewed-by: default avatarDong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
[CH: tweaked comment]
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent 198c0d1f

hw/s390x/css.c

+2 −1
Original line number Diff line number Diff line
@@ -885,7 +885,8 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr, 
            ret = -EINVAL;

            break;

        }

        if (ccw.flags & (CCW_FLAG_CC | CCW_FLAG_DC)) {

        if (ccw.flags || ccw.count) {

            /* We have already sanitized these if converted from fmt 0. */

            ret = -EINVAL;

            break;

        }