Commit 49921d68 authored by David Hildenbrand's avatar David Hildenbrand Committed by Richard Henderson
Browse files

target/s390x: addressing exceptions are suppressing 



We have to make the address in the old PSW point at the next
instruction, as addressing exceptions are suppressing and not
nullifying.

I assume that there are a lot of other broken cases (as most instructions
we care about are suppressing) - all trigger_pgm_exception() specifying
and explicit number or ILEN_LATER look suspicious, however this is another
story that might require bigger changes (and I have to understand when
the address might already have been incremented first).

This is needed to make an upcoming kvm-unit-test work.

Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <20170529121228.2789-1-david@redhat.com>
Signed-off-by: default avatarRichard Henderson <rth@twiddle.net>
parent 3190dfc5

target/s390x/helper.c

+1 −1
Original line number Diff line number Diff line
@@ -204,7 +204,7 @@ int s390_cpu_handle_mmu_fault(CPUState *cs, vaddr orig_vaddr, 
    if (raddr > ram_size) {

        DPRINTF("%s: raddr %" PRIx64 " > ram_size %" PRIx64 "\n", __func__,

                (uint64_t)raddr, (uint64_t)ram_size);

        trigger_pgm_exception(env, PGM_ADDRESSING, ILEN_LATER);

        trigger_pgm_exception(env, PGM_ADDRESSING, ILEN_LATER_INC);

        return 1;

    }