Commit 47a2def4 authored by Alex Bennée's avatar Alex Bennée Committed by Richard Henderson
Browse files

accel/tcg: remove link between guest ram and TCG cache size 



Basing the TB cache size on the ram_size was always a little heuristic
and was broken by a1b18df9 which caused ram_size not to be fully
realised at the time we initialise the TCG translation cache.

The current DEFAULT_CODE_GEN_BUFFER_SIZE may still be a little small
but follow-up patches will address that.

Fixes: a1b18df9
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Tested-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarNiek Linnenbank <nieklinnenbank@gmail.com>
Message-Id: <20200228192415.19867-3-alex.bennee@linaro.org>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
parent a2fa63a8

accel/tcg/translate-all.c

+0 −8
Original line number Diff line number Diff line
@@ -938,15 +938,7 @@ static inline size_t size_code_gen_buffer(size_t tb_size) 
{

    /* Size the buffer.  */

    if (tb_size == 0) {

#ifdef USE_STATIC_CODE_GEN_BUFFER

        tb_size = DEFAULT_CODE_GEN_BUFFER_SIZE;

#else

        /* ??? Needs adjustments.  */

        /* ??? If we relax the requirement that CONFIG_USER_ONLY use the

           static buffer, we could size this on RESERVED_VA, on the text

           segment size of the executable, or continue to use the default.  */

        tb_size = (unsigned long)(ram_size / 4);

#endif

    }

    if (tb_size < MIN_CODE_GEN_BUFFER_SIZE) {

        tb_size = MIN_CODE_GEN_BUFFER_SIZE;