Commit 47829c40 authored by Eric Blake's avatar Eric Blake
Browse files

nbd/client: Make x-dirty-bitmap more reliable 



The implementation of x-dirty-bitmap in qemu 3.0 (commit 216ee365)
silently falls back to treating the server as not supporting
NBD_CMD_BLOCK_STATUS if a requested meta_context name was not
negotiated, which in turn means treating the _entire_ image as
data. Since our hack relied on using 'qemu-img map' to view
which portions of the image were dirty by seeing what the
redirected bdrv_block_status() treats as holes, this means
that our fallback treats the entire image as clean.  Better
would have been to treat the entire image as dirty, or to fail
to connect because the user's request for a specific context
could not be honored. This patch goes with the latter.

Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Message-Id: <20181130023232.3079982-3-eblake@redhat.com>
Reviewed-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
parent e31d8024

block/nbd-client.c

+5 −0
Original line number Diff line number Diff line
@@ -992,6 +992,11 @@ int nbd_client_init(BlockDriverState *bs, 
        logout("Failed to negotiate with the NBD server\n");

        return ret;

    }

    if (x_dirty_bitmap && !client->info.base_allocation) {

        error_setg(errp, "requested x-dirty-bitmap %s not found",

                   x_dirty_bitmap);

        return -EINVAL;

    }

    if (client->info.flags & NBD_FLAG_READ_ONLY) {

        ret = bdrv_apply_auto_read_only(bs, "NBD export is read-only", errp);

        if (ret < 0) {