Commit 46f5ac20 authored by Eric Blake's avatar Eric Blake Committed by Markus Armbruster
Browse files

qobject: Use simpler QDict/QList scalar insertion macros 



We now have macros in place to make it less verbose to add a scalar
to QDict and QList, so use them.

Patch created mechanically via:
  spatch --sp-file scripts/coccinelle/qobject.cocci \
    --macro-file scripts/cocci-macro-file.h --dir . --in-place
then touched up manually to fix a couple of '?:' back to original
spacing, as well as avoiding a long line in monitor.c.

Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <20170427215821.19397-7-eblake@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: default avatarAlberto Garcia <berto@igalia.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent a92c2159

block.c

+19 −26
Original line number Diff line number Diff line
@@ -974,16 +974,14 @@ static void update_flags_from_options(int *flags, QemuOpts *opts) 
static void update_options_from_flags(QDict *options, int flags)

{

    if (!qdict_haskey(options, BDRV_OPT_CACHE_DIRECT)) {

        qdict_put(options, BDRV_OPT_CACHE_DIRECT,

                  qbool_from_bool(flags & BDRV_O_NOCACHE));

        qdict_put_bool(options, BDRV_OPT_CACHE_DIRECT, flags & BDRV_O_NOCACHE);

    }

    if (!qdict_haskey(options, BDRV_OPT_CACHE_NO_FLUSH)) {

        qdict_put(options, BDRV_OPT_CACHE_NO_FLUSH,

                  qbool_from_bool(flags & BDRV_O_NO_FLUSH));

        qdict_put_bool(options, BDRV_OPT_CACHE_NO_FLUSH,

                       flags & BDRV_O_NO_FLUSH);

    }

    if (!qdict_haskey(options, BDRV_OPT_READ_ONLY)) {

        qdict_put(options, BDRV_OPT_READ_ONLY,

                  qbool_from_bool(!(flags & BDRV_O_RDWR)));

        qdict_put_bool(options, BDRV_OPT_READ_ONLY, !(flags & BDRV_O_RDWR));

    }

}
@@ -1399,7 +1397,7 @@ static int bdrv_fill_options(QDict **options, const char *filename, 
    /* Fetch the file name from the options QDict if necessary */

    if (protocol && filename) {

        if (!qdict_haskey(*options, "filename")) {

            qdict_put(*options, "filename", qstring_from_str(filename));

            qdict_put_str(*options, "filename", filename);

            parse_filename = true;

        } else {

            error_setg(errp, "Can't specify 'file' and 'filename' options at "
@@ -1420,7 +1418,7 @@ static int bdrv_fill_options(QDict **options, const char *filename, 
            }



            drvname = drv->format_name;

            qdict_put(*options, "driver", qstring_from_str(drvname));

            qdict_put_str(*options, "driver", drvname);

        } else {

            error_setg(errp, "Must specify either driver or file");

            return -EINVAL;
@@ -2075,7 +2073,7 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options, 
    }



    if (bs->backing_format[0] != '\0' && !qdict_haskey(options, "driver")) {

        qdict_put(options, "driver", qstring_from_str(bs->backing_format));

        qdict_put_str(options, "driver", bs->backing_format);

    }



    backing_hd = bdrv_open_inherit(*backing_filename ? backing_filename : NULL,
@@ -2230,12 +2228,9 @@ static BlockDriverState *bdrv_append_temp_snapshot(BlockDriverState *bs, 
    }



    /* Prepare options QDict for the temporary file */

    qdict_put(snapshot_options, "file.driver",

              qstring_from_str("file"));

    qdict_put(snapshot_options, "file.filename",

              qstring_from_str(tmp_filename));

    qdict_put(snapshot_options, "driver",

              qstring_from_str("qcow2"));

    qdict_put_str(snapshot_options, "file.driver", "file");

    qdict_put_str(snapshot_options, "file.filename", tmp_filename);

    qdict_put_str(snapshot_options, "driver", "qcow2");



    bs_snapshot = bdrv_open(NULL, NULL, snapshot_options, flags, errp);

    snapshot_options = NULL;
@@ -2410,8 +2405,7 @@ static BlockDriverState *bdrv_open_inherit(const char *filename, 
                goto fail;

            }



            qdict_put(options, "file",

                      qstring_from_str(bdrv_get_node_name(file_bs)));

            qdict_put_str(options, "file", bdrv_get_node_name(file_bs));

        }

    }
@@ -2433,8 +2427,8 @@ static BlockDriverState *bdrv_open_inherit(const char *filename, 
         * sure to update both bs->options (which has the full effective

         * options for bs) and options (which has file.* already removed).

         */

        qdict_put(bs->options, "driver", qstring_from_str(drv->format_name));

        qdict_put(options, "driver", qstring_from_str(drv->format_name));

        qdict_put_str(bs->options, "driver", drv->format_name);

        qdict_put_str(options, "driver", drv->format_name);

    } else if (!drv) {

        error_setg(errp, "Must specify either driver or file");

        goto fail;
@@ -2810,12 +2804,12 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state, BlockReopenQueue *queue, 
     * that they are checked at the end of this function. */

    value = qemu_opt_get(opts, "node-name");

    if (value) {

        qdict_put(reopen_state->options, "node-name", qstring_from_str(value));

        qdict_put_str(reopen_state->options, "node-name", value);

    }



    value = qemu_opt_get(opts, "driver");

    if (value) {

        qdict_put(reopen_state->options, "driver", qstring_from_str(value));

        qdict_put_str(reopen_state->options, "driver", value);

    }



    /* If we are to stay read-only, do not allow permission change
@@ -4306,8 +4300,7 @@ void bdrv_img_create(const char *filename, const char *fmt, 


            if (backing_fmt) {

                backing_options = qdict_new();

                qdict_put(backing_options, "driver",

                          qstring_from_str(backing_fmt));

                qdict_put_str(backing_options, "driver", backing_fmt);

            }



            bs = bdrv_open(full_backing, NULL, backing_options, back_flags,
@@ -4712,7 +4705,7 @@ void bdrv_refresh_filename(BlockDriverState *bs) 
         * contain a representation of the filename, therefore the following

         * suffices without querying the (exact_)filename of this BDS. */

        if (bs->file->bs->full_open_options) {

            qdict_put(opts, "driver", qstring_from_str(drv->format_name));

            qdict_put_str(opts, "driver", drv->format_name);

            QINCREF(bs->file->bs->full_open_options);

            qdict_put(opts, "file", bs->file->bs->full_open_options);
@@ -4730,7 +4723,7 @@ void bdrv_refresh_filename(BlockDriverState *bs) 


        opts = qdict_new();

        append_open_options(opts, bs);

        qdict_put(opts, "driver", qstring_from_str(drv->format_name));

        qdict_put_str(opts, "driver", drv->format_name);



        if (bs->exact_filename[0]) {

            /* This may not work for all block protocol drivers (some may
@@ -4740,7 +4733,7 @@ void bdrv_refresh_filename(BlockDriverState *bs) 
             * needs some special format of the options QDict, it needs to

             * implement the driver-specific bdrv_refresh_filename() function.

             */

            qdict_put(opts, "filename", qstring_from_str(bs->exact_filename));

            qdict_put_str(opts, "filename", bs->exact_filename);

        }



        bs->full_open_options = opts;

block/blkdebug.c

+3 −3
Original line number Diff line number Diff line
@@ -301,7 +301,7 @@ static void blkdebug_parse_filename(const char *filename, QDict *options, 
    if (!strstart(filename, "blkdebug:", &filename)) {

        /* There was no prefix; therefore, all options have to be already

           present in the QDict (except for the filename) */

        qdict_put(options, "x-image", qstring_from_str(filename));

        qdict_put_str(options, "x-image", filename);

        return;

    }
@@ -320,7 +320,7 @@ static void blkdebug_parse_filename(const char *filename, QDict *options, 


    /* TODO Allow multi-level nesting and set file.filename here */

    filename = c + 1;

    qdict_put(options, "x-image", qstring_from_str(filename));

    qdict_put_str(options, "x-image", filename);

}



static QemuOptsList runtime_opts = {
@@ -693,7 +693,7 @@ static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) 
    }



    opts = qdict_new();

    qdict_put(opts, "driver", qstring_from_str("blkdebug"));

    qdict_put_str(opts, "driver", "blkdebug");



    QINCREF(bs->file->bs->full_open_options);

    qdict_put(opts, "image", bs->file->bs->full_open_options);

block/blkverify.c

+3 −3
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ static void blkverify_parse_filename(const char *filename, QDict *options, 
    if (!strstart(filename, "blkverify:", &filename)) {

        /* There was no prefix; therefore, all options have to be already

           present in the QDict (except for the filename) */

        qdict_put(options, "x-image", qstring_from_str(filename));

        qdict_put_str(options, "x-image", filename);

        return;

    }
@@ -84,7 +84,7 @@ static void blkverify_parse_filename(const char *filename, QDict *options, 


    /* TODO Allow multi-level nesting and set file.filename here */

    filename = c + 1;

    qdict_put(options, "x-image", qstring_from_str(filename));

    qdict_put_str(options, "x-image", filename);

}



static QemuOptsList runtime_opts = {
@@ -288,7 +288,7 @@ static void blkverify_refresh_filename(BlockDriverState *bs, QDict *options) 
        && s->test_file->bs->full_open_options)

    {

        QDict *opts = qdict_new();

        qdict_put(opts, "driver", qstring_from_str("blkverify"));

        qdict_put_str(opts, "driver", "blkverify");



        QINCREF(bs->file->bs->full_open_options);

        qdict_put(opts, "raw", bs->file->bs->full_open_options);

block/curl.c

+1 −1
Original line number Diff line number Diff line
@@ -548,7 +548,7 @@ static void curl_clean_state(CURLState *s) 
static void curl_parse_filename(const char *filename, QDict *options,

                                Error **errp)

{

    qdict_put(options, CURL_BLOCK_OPT_URL, qstring_from_str(filename));

    qdict_put_str(options, CURL_BLOCK_OPT_URL, filename);

}



static void curl_detach_aio_context(BlockDriverState *bs)

block/file-posix.c

+4 −4
Original line number Diff line number Diff line
@@ -375,7 +375,7 @@ static void raw_parse_filename(const char *filename, QDict *options, 
     * function call can be ignored. */

    strstart(filename, "file:", &filename);



    qdict_put(options, "filename", qstring_from_str(filename));

    qdict_put_str(options, "filename", filename);

}



static QemuOptsList raw_runtime_opts = {
@@ -2155,7 +2155,7 @@ static void hdev_parse_filename(const char *filename, QDict *options, 
    /* The prefix is optional, just as for "file". */

    strstart(filename, "host_device:", &filename);



    qdict_put(options, "filename", qstring_from_str(filename));

    qdict_put_str(options, "filename", filename);

}



static bool hdev_is_sg(BlockDriverState *bs)
@@ -2244,7 +2244,7 @@ static int hdev_open(BlockDriverState *bs, QDict *options, int flags, 
            goto hdev_open_Mac_error;

        }



        qdict_put(options, "filename", qstring_from_str(bsd_path));

        qdict_put_str(options, "filename", bsd_path);



hdev_open_Mac_error:

        g_free(mediaType);
@@ -2454,7 +2454,7 @@ static void cdrom_parse_filename(const char *filename, QDict *options, 
    /* The prefix is optional, just as for "file". */

    strstart(filename, "host_cdrom:", &filename);



    qdict_put(options, "filename", qstring_from_str(filename));

    qdict_put_str(options, "filename", filename);

}

#endif