Commit 46517dd4 authored by Markus Armbruster's avatar Markus Armbruster
Browse files

Include sysemu/sysemu.h a lot less 



In my "build everything" tree, changing sysemu/sysemu.h triggers a
recompile of some 5400 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).

hw/qdev-core.h includes sysemu/sysemu.h since recent commit e965ffa7
"qdev: add qdev_add_vm_change_state_handler()".  This is a bad idea:
hw/qdev-core.h is widely included.

Move the declaration of qdev_add_vm_change_state_handler() to
sysemu/sysemu.h, and drop the problematic include from hw/qdev-core.h.

Touching sysemu/sysemu.h now recompiles some 1800 objects.
qemu/uuid.h also drops from 5400 to 1800.  A few more headers show
smaller improvement: qemu/notify.h drops from 5600 to 5200,
qemu/timer.h from 5600 to 4500, and qapi/qapi-types-run-state.h from
5500 to 5000.

Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarAlistair Francis <alistair.francis@wdc.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20190812052359.30071-28-armbru@redhat.com>
Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
parent d5938f29

accel/kvm/kvm-all.c

+1 −0
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ 
#include "exec/gdbstub.h"

#include "sysemu/kvm_int.h"

#include "sysemu/cpus.h"

#include "sysemu/sysemu.h"

#include "qemu/bswap.h"

#include "exec/memory.h"

#include "exec/ram_addr.h"

backends/hostmem.c

+1 −0
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 


#include "qemu/osdep.h"

#include "sysemu/hostmem.h"

#include "sysemu/sysemu.h"

#include "hw/boards.h"

#include "qapi/error.h"

#include "qapi/qapi-builtin-visit.h"

cpus.c

+1 −0
Original line number Diff line number Diff line
@@ -41,6 +41,7 @@ 
#include "sysemu/kvm.h"

#include "sysemu/hax.h"

#include "sysemu/hvf.h"

#include "sysemu/sysemu.h"

#include "sysemu/whpx.h"

#include "exec/exec-all.h"

hw/arm/allwinner-a10.c

+1 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 
#include "hw/sysbus.h"

#include "hw/arm/allwinner-a10.h"

#include "hw/misc/unimp.h"

#include "sysemu/sysemu.h"



static void aw_a10_init(Object *obj)

{

hw/arm/aspeed_soc.c

+1 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 
#include "qemu/error-report.h"

#include "hw/i2c/aspeed_i2c.h"

#include "net/net.h"

#include "sysemu/sysemu.h"



#define ASPEED_SOC_IOMEM_SIZE       0x00200000