Commit 46036b24 authored by Aníbal Limón's avatar Aníbal Limón Committed by Paolo Bonzini
Browse files

cpus.c: qemu_mutex_lock_iothread fix race condition at cpu thread init 

When QEMU starts the RCU thread executes qemu_mutex_lock_thread
causing error "qemu:qemu_cpu_kick_thread: No such process" and exits.

This isn't occur frequently but in glibc the thread id can exist and
this not guarantee that the thread is on active/running state. If is
inserted a sleep(1) after newthread assignment [1] the issue appears.

So not make assumption that thread exist if first_cpu->thread is set
then change the validation of cpu to created that is set into cpu
threads (kvm, tcg, dummy).

[1] https://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/pthread_create.c;h=d10f4ea8004e1d8f3a268b95cc0f8d93b8d89867;hb=HEAD#l621



Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarAníbal Limón <anibal.limon@linux.intel.com>
Message-Id: <1441313313-3040-1-git-send-email-anibal.limon@linux.intel.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent d12f7309

cpus.c

+1 −1
Original line number Diff line number Diff line
@@ -1166,7 +1166,7 @@ void qemu_mutex_lock_iothread(void) 
     * TCG code execution.

     */

    if (!tcg_enabled() || qemu_in_vcpu_thread() ||

        !first_cpu || !first_cpu->thread) {

        !first_cpu || !first_cpu->created) {

        qemu_mutex_lock(&qemu_global_mutex);

        atomic_dec(&iothread_requesting_mutex);

    } else {