Commit 45a9eace authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Laurent Vivier
Browse files

hw/dma/omap_dma: Move switch 'fall through' comment to correct place 



Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:

    CC      hw/dma/omap_dma.o
  hw/dma/omap_dma.c: In function ‘omap_dma_write’:
  hw/dma/omap_dma.c:1532:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
   1532 |         if (s->model <= omap_dma_3_1)
        |            ^
  hw/dma/omap_dma.c:1534:5: note: here
   1534 |     case 0x400:
        |     ^~~~
  cc1: all warnings being treated as errors

Correctly place the 'fall through' comment.

Reported-by: default avatarStefan Weil <sw@weilnetz.de>
Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Message-Id: <20190719131425.10835-3-philmd@redhat.com>
Signed-off-by: default avatarLaurent Vivier <laurent@vivier.eu>
parent 6f0dd6c5

hw/dma/omap_dma.c

+1 −1
Original line number Diff line number Diff line
@@ -1531,8 +1531,8 @@ static void omap_dma_write(void *opaque, hwaddr addr, 
    case 0x404 ... 0x4fe:

        if (s->model <= omap_dma_3_1)

            break;

        /* fall through */

    case 0x400:

        /* Fall through. */

        if (omap_dma_sys_write(s, addr, value))

            break;

        return;