Commit 4591bd46 authored by Marc-André Lureau's avatar Marc-André Lureau
Browse files

char-socket: make 'fd' incompatible with 'reconnect' 



A chardev socket created with the 'fd=' argument is not going to
handle reconnection properly by recycling the same fd (or not in a
supported way). Let's forbid this case.

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
parent 3b023756

chardev/char-socket.c

+4 −0
Original line number Diff line number Diff line
@@ -997,6 +997,10 @@ static void qmp_chardev_open_socket(Chardev *chr, 


    s->addr = addr = socket_address_flatten(sock->addr);



    if (sock->has_reconnect && addr->type == SOCKET_ADDRESS_TYPE_FD) {

        error_setg(errp, "'reconnect' option is incompatible with 'fd'");

        goto error;

    }

    qemu_chr_set_feature(chr, QEMU_CHAR_FEATURE_RECONNECTABLE);

    /* TODO SOCKET_ADDRESS_FD where fd has AF_UNIX */

    if (addr->type == SOCKET_ADDRESS_TYPE_UNIX) {