Commit 4577b09a authored by Peter Maydell's avatar Peter Maydell Committed by Samuel Thibault
Browse files

slirp: Check qemu_socket() return value in udp_listen() 



Check the return value from qemu_socket() rather than trying to
pass it to bind() as an fd argument even if it's negative.
This wouldn't have caused any negative consequences, because
it won't be a valid fd number and the bind call will fail;
but Coverity complains (CID 1005723).

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: default avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
parent 6528a4c1

slirp/udp.c

+4 −0
Original line number Diff line number Diff line
@@ -335,6 +335,10 @@ udp_listen(Slirp *slirp, uint32_t haddr, u_int hport, uint32_t laddr, 
	    return NULL;

	}

	so->s = qemu_socket(AF_INET,SOCK_DGRAM,0);

        if (so->s < 0) {

            sofree(so);

            return NULL;

        }

	so->so_expire = curtime + SO_EXPIRE;

	insque(so, &slirp->udb);