Commit 4500bc98 authored by Marcel Apfelbaum's avatar Marcel Apfelbaum Committed by Michael S. Tsirkin
Browse files

acpi unit-test: hook to rebuild expected aml files 



When running the test with TEST_ACPI_REBUILD_AML=y environment
variable, the test will rebuild and validate the expected aml
files.

Signed-off-by: default avatarMarcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent cebc92a2

tests/acpi-test.c

+25 −5
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
#include <string.h>

#include <stdio.h>

#include <glib.h>

#include <glib/gstdio.h>

#include "qemu-common.h"

#include "libqtest.h"

#include "qemu/compiler.h"
@@ -21,6 +22,8 @@ 
#define MACHINE_PC "pc"

#define MACHINE_Q35 "q35"



#define ACPI_REBUILD_EXPECTED_AML "TEST_ACPI_REBUILD_AML"



/* DSDT and SSDTs format */

typedef struct {

    AcpiTableHeader header;
@@ -363,10 +366,11 @@ static void test_acpi_ssdt_tables(test_data *data) 
    }

}



static void dump_aml_files(test_data *data)

static void dump_aml_files(test_data *data, bool rebuild)

{

    AcpiSdtTable *sdt;

    GError *error = NULL;

    gchar *aml_file = NULL;

    gint fd;

    ssize_t ret;

    int i;
@@ -375,8 +379,16 @@ static void dump_aml_files(test_data *data) 
        sdt = &g_array_index(data->ssdt_tables, AcpiSdtTable, i);

        g_assert(sdt->aml);



        if (rebuild) {

            aml_file = g_strdup_printf("%s/%s/%.4s", data_dir, data->machine,

                                       (gchar *)&sdt->header.signature);

            fd = g_open(aml_file, O_WRONLY|O_TRUNC|O_CREAT,

                        S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH);

        } else {

            fd = g_file_open_tmp("aml-XXXXXX", &sdt->aml_file, &error);

            g_assert_no_error(error);

        }

        g_assert(fd >= 0);



        ret = qemu_write_full(fd, sdt, sizeof(AcpiTableHeader));

        g_assert(ret == sizeof(AcpiTableHeader));
@@ -384,6 +396,10 @@ static void dump_aml_files(test_data *data) 
        g_assert(ret == sdt->aml_len);



        close(fd);



        if (aml_file) {

            g_free(aml_file);

        }

    }

}
@@ -491,7 +507,7 @@ static void test_acpi_asl(test_data *data) 


    memset(&exp_data, 0, sizeof(exp_data));

    exp_data.ssdt_tables = load_expected_aml(data);

    dump_aml_files(data);

    dump_aml_files(data, false);

    for (i = 0; i < data->ssdt_tables->len; ++i) {

        GString *asl, *exp_asl;
@@ -557,8 +573,12 @@ static void test_acpi_one(const char *params, test_data *data) 
    test_acpi_ssdt_tables(data);



    if (iasl) {

        if (getenv(ACPI_REBUILD_EXPECTED_AML)) {

            dump_aml_files(data, true);

        } else {

            test_acpi_asl(data);

        }

    }



    qtest_quit(global_qtest);

    g_free(args);