Commit 4473348a authored by Ross Lagerwall's avatar Ross Lagerwall Committed by Ian Jackson
Browse files

xen: Expect xenstore write to fail when restricted 



Saving the current state to xenstore may fail when running restricted
(in particular, after a migration). Therefore, don't report the error or
exit when running restricted.  Toolstacks that want to allow running
QEMU restricted should instead make use of QMP events to listen for
state changes.

CC: Ian Jackson <ian.jackson@eu.citrix.com>
Signed-off-by: default avatarRoss Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: default avatarIan Jackson <ian.jackson@eu.citrix.com>
Acked-by: default avatarAnthony PERARD <anthony.perard@citrix.com>
parent 1c4010fa

hw/xen/xen-common.c

+6 −1
Original line number Diff line number Diff line
@@ -101,7 +101,12 @@ static void xenstore_record_dm_state(struct xs_handle *xs, const char *state) 
    }



    snprintf(path, sizeof (path), "device-model/%u/state", xen_domid);

    if (!xs_write(xs, XBT_NULL, path, state, strlen(state))) {

    /*

     * This call may fail when running restricted so don't make it fatal in

     * that case. Toolstacks should instead use QMP to listen for state changes.

     */

    if (!xs_write(xs, XBT_NULL, path, state, strlen(state)) &&

            !xen_domid_restrict) {

        error_report("error recording dm state");

        exit(1);

    }