Commit 444ba679 authored by Orit Wasserman's avatar Orit Wasserman Committed by Juan Quintela
Browse files

Fix real mode guest migration 



Older KVM versions save CS dpl value to an invalid value for real mode guests
(0x3). This patch detect this situation when loading CPU state and set all the
segments dpl to zero.
This will allow migration from older KVM on host without unrestricted guest
to hosts with restricted guest support.
For example migration from a Penryn host (with kernel 2.6.32) to
a Westmere host (for real mode guest) will fail with "kvm: unhandled exit 80000021".

Signed-off-by: default avatarOrit Wasserman <owasserm@redhat.com>
Reviewed-by: default avatarJuan Quintela <quintela@redhat.com>
Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
parent ed4fbd10

target-i386/machine.c

+18 −0
Original line number Diff line number Diff line
@@ -260,6 +260,24 @@ static int cpu_post_load(void *opaque, int version_id) 
    CPUX86State *env = &cpu->env;

    int i;



    /*

     * Real mode guest segments register DPL should be zero.

     * Older KVM version were setting it wrongly.

     * Fixing it will allow live migration from such host that don't have

     * restricted guest support to a host with unrestricted guest support

     * (otherwise the migration will fail with invalid guest state

     * error).

     */

    if (!(env->cr[0] & CR0_PE_MASK) &&

        (env->segs[R_CS].flags >> DESC_DPL_SHIFT & 3) != 0) {

        env->segs[R_CS].flags &= ~(env->segs[R_CS].flags & DESC_DPL_MASK);

        env->segs[R_DS].flags &= ~(env->segs[R_DS].flags & DESC_DPL_MASK);

        env->segs[R_ES].flags &= ~(env->segs[R_ES].flags & DESC_DPL_MASK);

        env->segs[R_FS].flags &= ~(env->segs[R_FS].flags & DESC_DPL_MASK);

        env->segs[R_GS].flags &= ~(env->segs[R_GS].flags & DESC_DPL_MASK);

        env->segs[R_SS].flags &= ~(env->segs[R_SS].flags & DESC_DPL_MASK);

    }



    /* XXX: restore FPU round state */

    env->fpstt = (env->fpus_vmstate >> 11) & 7;

    env->fpus = env->fpus_vmstate & ~0x3800;