Commit 43eaaaef authored by Max Reitz's avatar Max Reitz
Browse files

block: Only the main loop can change AioContexts 



bdrv_set_aio_context_ignore() can only work in the main loop:
bdrv_drained_begin() only works in the main loop and the node's (old)
AioContext; and bdrv_drained_end() really only works in the main loop
and the node's (new) AioContext (contrary to its current comment, which
is just wrong).

Consequentially, bdrv_set_aio_context_ignore() must be called from the
main loop.  Luckily, assuming that we can make block graph changes only
from the main loop as well, all its callers do that already.

Note that changing a node's context in a sense is an operation that
changes the block graph, so it actually makes sense to require this
function to be called from the main loop.

Also, fix bdrv_drained_end()'s description.  You can only use it from
the main loop or the node's AioContext, and in the latter case, the
whole subtree must be in the same context.

Fixes: e037c09c
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Message-id: 20190722133054.21781-3-mreitz@redhat.com
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 65181d63

block.c

+8 −5
Original line number Diff line number Diff line
@@ -5914,6 +5914,8 @@ static void bdrv_attach_aio_context(BlockDriverState *bs, 
 * Changes the AioContext used for fd handlers, timers, and BHs by this

 * BlockDriverState and all its children and parents.

 *

 * Must be called from the main AioContext.

 *

 * The caller must own the AioContext lock for the old AioContext of bs, but it

 * must not own the AioContext lock for new_context (unless new_context is the

 * same as the current context of bs).
@@ -5925,9 +5927,10 @@ void bdrv_set_aio_context_ignore(BlockDriverState *bs, 
                                 AioContext *new_context, GSList **ignore)

{

    AioContext *old_context = bdrv_get_aio_context(bs);

    AioContext *current_context = qemu_get_current_aio_context();

    BdrvChild *child;



    g_assert(qemu_get_current_aio_context() == qemu_get_aio_context());



    if (old_context == new_context) {

        return;

    }
@@ -5953,7 +5956,7 @@ void bdrv_set_aio_context_ignore(BlockDriverState *bs, 
    bdrv_detach_aio_context(bs);



    /* Acquire the new context, if necessary */

    if (current_context != new_context) {

    if (qemu_get_aio_context() != new_context) {

        aio_context_acquire(new_context);

    }
@@ -5965,16 +5968,16 @@ void bdrv_set_aio_context_ignore(BlockDriverState *bs, 
     * subtree that have not yet been moved to the new AioContext.

     * Release the old one so bdrv_drained_end() can poll them.

     */

    if (current_context != old_context) {

    if (qemu_get_aio_context() != old_context) {

        aio_context_release(old_context);

    }



    bdrv_drained_end(bs);



    if (current_context != old_context) {

    if (qemu_get_aio_context() != old_context) {

        aio_context_acquire(old_context);

    }

    if (current_context != new_context) {

    if (qemu_get_aio_context() != new_context) {

        aio_context_release(new_context);

    }

}

include/block/block.h

+3 −5
Original line number Diff line number Diff line
@@ -667,11 +667,9 @@ void bdrv_subtree_drained_begin(BlockDriverState *bs); 
 *

 * This polls @bs's AioContext until all scheduled sub-drained_ends

 * have settled.  On one hand, that may result in graph changes.  On

 * the other, this requires that all involved nodes (@bs and all of

 * its parents) are in the same AioContext, and that the caller has

 * acquired it.

 * If there are any nodes that are in different contexts from @bs,

 * these contexts must not be acquired.

 * the other, this requires that the caller either runs in the main

 * loop; or that all involved nodes (@bs and all of its parents) are

 * in the caller's AioContext.

 */

void bdrv_drained_end(BlockDriverState *bs);