Commit 42a48128 authored by Kevin Wolf's avatar Kevin Wolf
Browse files

Merge remote-tracking branch 'mreitz/tags/pull-block-2017-05-29-v3' into queue-block 



Block patches for the block queue

# gpg: Signature made Mon May 29 16:32:16 2017 CEST
# gpg:                using RSA key 0xF407DB0061D5CF40
# gpg: Good signature from "Max Reitz <mreitz@redhat.com>"
# Primary key fingerprint: 91BE B60A 30DB 3E88 57D1  1829 F407 DB00 61D5 CF40

* mreitz/tags/pull-block-2017-05-29-v3:
  block/file-*: *_parse_filename() and colons
  block: Fix backing paths for filenames with colons
  block: Tweak error message related to qemu-img amend
  qemu-img: Fix leakage of options on error
  qemu-img: copy *key-secret opts when opening newly created files
  qemu-img: introduce --target-image-opts for 'convert' command
  qemu-img: fix --image-opts usage with dd command
  qemu-img: add support for --object with 'dd' command
  qemu-img: Fix documentation of convert
  qcow2: remove extra local_error variable

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parents 63c8ef28 03c320d8

block.c

+45 −5
Original line number Diff line number Diff line
@@ -163,11 +163,16 @@ void path_combine(char *dest, int dest_size, 
    if (path_is_absolute(filename)) {

        pstrcpy(dest, dest_size, filename);

    } else {

        p = strchr(base_path, ':');

        if (p)

            p++;

        else

            p = base_path;

        const char *protocol_stripped = NULL;



        if (path_has_protocol(base_path)) {

            protocol_stripped = strchr(base_path, ':');

            if (protocol_stripped) {

                protocol_stripped++;

            }

        }

        p = protocol_stripped ?: base_path;



        p1 = strrchr(base_path, '/');

#ifdef _WIN32

        {
@@ -192,6 +197,41 @@ void path_combine(char *dest, int dest_size, 
    }

}



/*

 * Helper function for bdrv_parse_filename() implementations to remove optional

 * protocol prefixes (especially "file:") from a filename and for putting the

 * stripped filename into the options QDict if there is such a prefix.

 */

void bdrv_parse_filename_strip_prefix(const char *filename, const char *prefix,

                                      QDict *options)

{

    if (strstart(filename, prefix, &filename)) {

        /* Stripping the explicit protocol prefix may result in a protocol

         * prefix being (wrongly) detected (if the filename contains a colon) */

        if (path_has_protocol(filename)) {

            QString *fat_filename;



            /* This means there is some colon before the first slash; therefore,

             * this cannot be an absolute path */

            assert(!path_is_absolute(filename));



            /* And we can thus fix the protocol detection issue by prefixing it

             * by "./" */

            fat_filename = qstring_from_str("./");

            qstring_append(fat_filename, filename);



            assert(!path_has_protocol(qstring_get_str(fat_filename)));



            qdict_put(options, "filename", fat_filename);

        } else {

            /* If no protocol prefix was detected, we can use the shortened

             * filename as-is */

            qdict_put_str(options, "filename", filename);

        }

    }

}





/* Returns whether the image file is opened as read-only. Note that this can

 * return false and writing to the image file is still not possible because the

 * image is inactivated. */

block/file-posix.c

+3 −14
Original line number Diff line number Diff line
@@ -381,12 +381,7 @@ static void raw_parse_flags(int bdrv_flags, int *open_flags) 
static void raw_parse_filename(const char *filename, QDict *options,

                               Error **errp)

{

    /* The filename does not have to be prefixed by the protocol name, since

     * "file" is the default protocol; therefore, the return value of this

     * function call can be ignored. */

    strstart(filename, "file:", &filename);



    qdict_put_str(options, "filename", filename);

    bdrv_parse_filename_strip_prefix(filename, "file:", options);

}



static QemuOptsList raw_runtime_opts = {
@@ -2395,10 +2390,7 @@ static int check_hdev_writable(BDRVRawState *s) 
static void hdev_parse_filename(const char *filename, QDict *options,

                                Error **errp)

{

    /* The prefix is optional, just as for "file". */

    strstart(filename, "host_device:", &filename);



    qdict_put_str(options, "filename", filename);

    bdrv_parse_filename_strip_prefix(filename, "host_device:", options);

}



static bool hdev_is_sg(BlockDriverState *bs)
@@ -2697,10 +2689,7 @@ static BlockDriver bdrv_host_device = { 
static void cdrom_parse_filename(const char *filename, QDict *options,

                                 Error **errp)

{

    /* The prefix is optional, just as for "file". */

    strstart(filename, "host_cdrom:", &filename);



    qdict_put_str(options, "filename", filename);

    bdrv_parse_filename_strip_prefix(filename, "host_cdrom:", options);

}

#endif

block/file-win32.c

+2 −10
Original line number Diff line number Diff line
@@ -276,12 +276,7 @@ static void raw_parse_flags(int flags, bool use_aio, int *access_flags, 
static void raw_parse_filename(const char *filename, QDict *options,

                               Error **errp)

{

    /* The filename does not have to be prefixed by the protocol name, since

     * "file" is the default protocol; therefore, the return value of this

     * function call can be ignored. */

    strstart(filename, "file:", &filename);



    qdict_put_str(options, "filename", filename);

    bdrv_parse_filename_strip_prefix(filename, "file:", options);

}



static QemuOptsList raw_runtime_opts = {
@@ -671,10 +666,7 @@ static int hdev_probe_device(const char *filename) 
static void hdev_parse_filename(const char *filename, QDict *options,

                                Error **errp)

{

    /* The prefix is optional, just as for "file". */

    strstart(filename, "host_device:", &filename);



    qdict_put_str(options, "filename", filename);

    bdrv_parse_filename_strip_prefix(filename, "host_device:", options);

}



static int hdev_open(BlockDriverState *bs, QDict *options, int flags,

block/qcow2-cluster.c

+2 −1
Original line number Diff line number Diff line
@@ -1797,7 +1797,8 @@ static int expand_zero_clusters_in_l1(BlockDriverState *bs, uint64_t *l1_table, 
            }



            if (offset_into_cluster(s, offset)) {

                qcow2_signal_corruption(bs, true, -1, -1, "Data cluster offset "

                qcow2_signal_corruption(bs, true, -1, -1,

                                        "Cluster allocation offset "

                                        "%#" PRIx64 " unaligned (L2 offset: %#"

                                        PRIx64 ", L2 index: %#x)", offset,

                                        l2_offset, j);

block/qcow2.c

+2 −3
Original line number Diff line number Diff line
@@ -3222,7 +3222,6 @@ static int qcow2_amend_options(BlockDriverState *bs, QemuOpts *opts, 


    if (s->refcount_bits != refcount_bits) {

        int refcount_order = ctz32(refcount_bits);

        Error *local_error = NULL;



        if (new_version < 3 && refcount_bits != 16) {

            error_report("Different refcount widths than 16 bits require "
@@ -3234,9 +3233,9 @@ static int qcow2_amend_options(BlockDriverState *bs, QemuOpts *opts, 
        helper_cb_info.current_operation = QCOW2_CHANGING_REFCOUNT_ORDER;

        ret = qcow2_change_refcount_order(bs, refcount_order,

                                          &qcow2_amend_helper_cb,

                                          &helper_cb_info, &local_error);

                                          &helper_cb_info, &local_err);

        if (ret < 0) {

            error_report_err(local_error);

            error_report_err(local_err);

            return ret;

        }

    }