Commit 403a905b authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Greg Kurz
Browse files

9pfs: avoid sign conversion error simplifying the code 



(note this is how other functions also handle the errors).

hw/9pfs/9p.c:948:18: warning: Loss of sign in implicit conversion
        offset = err;
                 ^~~

Reported-by: Clang Static Analyzer
Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
parent 53e2c48d

hw/9pfs/9p.c

+2 −4
Original line number Diff line number Diff line
@@ -945,7 +945,6 @@ static void coroutine_fn v9fs_version(void *opaque) 
    v9fs_string_init(&version);

    err = pdu_unmarshal(pdu, offset, "ds", &s->msize, &version);

    if (err < 0) {

        offset = err;

        goto out;

    }

    trace_v9fs_version(pdu->tag, pdu->id, s->msize, version.data);
@@ -962,13 +961,12 @@ static void coroutine_fn v9fs_version(void *opaque) 


    err = pdu_marshal(pdu, offset, "ds", s->msize, &version);

    if (err < 0) {

        offset = err;

        goto out;

    }

    offset += err;

    err += offset;

    trace_v9fs_version_return(pdu->tag, pdu->id, s->msize, version.data);

out:

    pdu_complete(pdu, offset);

    pdu_complete(pdu, err);

    v9fs_string_free(&version);

}