Commit 3efffc32 authored by Radoslav Gerganov's avatar Radoslav Gerganov Committed by Kevin Wolf
Browse files

vmdk: Fix next_cluster_sector for compressed write



When the VMDK is streamOptimized (or compressed), the
next_cluster_sector must not be incremented by a fixed number of
sectors. Instead of this, it must be rounded up to the next consecutive
sector. Fixing this results in much smaller compressed images.

Signed-off-by: default avatarRadoslav Gerganov <rgerganov@vmware.com>
Reviewed-by: default avatarFam Zheng <famz@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 097b500c
Loading
Loading
Loading
Loading
+6 −2
Original line number Diff line number Diff line
@@ -1324,8 +1324,12 @@ static int vmdk_write_extent(VmdkExtent *extent, int64_t cluster_offset,

    write_end_sector = DIV_ROUND_UP(write_offset + write_len, BDRV_SECTOR_SIZE);

    if (extent->compressed) {
        extent->next_cluster_sector = write_end_sector;
    } else {
        extent->next_cluster_sector = MAX(extent->next_cluster_sector,
                                          write_end_sector);
    }

    if (ret != write_len) {
        ret = ret < 0 ? ret : -EIO;