Commit 3eff3769 authored by Greg Kurz's avatar Greg Kurz Committed by Michael S. Tsirkin
Browse files

virtio-pci: error out when both legacy and modern modes are disabled 



Without presuming if we got there because of a user mistake or some
more subtle bug in the tooling, it really does not make sense to
implement a non-functional device.

Signed-off-by: default avatarGreg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: default avatarMarcel Apfelbaum <marcel@redhat.com>
Reviewed-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 4a1e48be

hw/virtio/virtio-pci.c

+8 −0
Original line number Diff line number Diff line
@@ -1776,6 +1776,14 @@ static void virtio_pci_realize(PCIDevice *pci_dev, Error **errp) 
        proxy->disable_legacy = pcie_port ? ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF;

    }



    if (!(virtio_pci_modern(proxy) || virtio_pci_legacy(proxy))) {

        error_setg(errp, "device cannot work as neither modern nor legacy mode"

                   " is enabled");

        error_append_hint(errp, "Set either disable-modern or disable-legacy"

                          " to off\n");

        return;

    }



    if (pcie_port && pci_is_express(pci_dev)) {

        int pos;