Commit 3ea6d20e authored by Thomas Huth's avatar Thomas Huth Committed by Cornelia Huck
Browse files

s390x/s390-stattrib: Mark the storage attribute as not user_creatable 



The storage attribute devices are only meant to be instantiated one
time, internally. They can not be used by the user, so mark them with
user_creatable = false.

Suggested-by: default avatarClaudio Imbrenda <imbrenda@linux.vnet.ibm.com>
Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Message-Id: <1503576029-24264-1-git-send-email-thuth@redhat.com>
Reviewed-by: default avatarClaudio Imbrenda <imbrenda@linux.vnet.ibm.com>
Reviewed-by: default avatarHalil Pasic <pasic@linux.vnet.ibm.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent c862bddb

hw/s390x/s390-stattrib-kvm.c

+4 −0
Original line number Diff line number Diff line
@@ -164,6 +164,7 @@ static int kvm_s390_stattrib_get_active(S390StAttribState *sa) 
static void kvm_s390_stattrib_class_init(ObjectClass *oc, void *data)

{

    S390StAttribClass *sac = S390_STATTRIB_CLASS(oc);

    DeviceClass *dc = DEVICE_CLASS(oc);



    sac->get_stattr = kvm_s390_stattrib_get_stattr;

    sac->peek_stattr = kvm_s390_stattrib_peek_stattr;
@@ -172,6 +173,9 @@ static void kvm_s390_stattrib_class_init(ObjectClass *oc, void *data) 
    sac->get_dirtycount = kvm_s390_stattrib_get_dirtycount;

    sac->synchronize = kvm_s390_stattrib_synchronize;

    sac->get_active = kvm_s390_stattrib_get_active;



    /* Reason: Can only be instantiated one time (internally) */

    dc->user_creatable = false;

}



static const TypeInfo kvm_s390_stattrib_info = {

hw/s390x/s390-stattrib.c

+4 −0
Original line number Diff line number Diff line
@@ -306,6 +306,7 @@ static int qemu_s390_get_active(S390StAttribState *sa) 
static void qemu_s390_stattrib_class_init(ObjectClass *oc, void *data)

{

    S390StAttribClass *sa_cl = S390_STATTRIB_CLASS(oc);

    DeviceClass *dc = DEVICE_CLASS(oc);



    sa_cl->synchronize = qemu_s390_synchronize_stub;

    sa_cl->get_stattr = qemu_s390_get_stattr_stub;
@@ -314,6 +315,9 @@ static void qemu_s390_stattrib_class_init(ObjectClass *oc, void *data) 
    sa_cl->set_migrationmode = qemu_s390_set_migrationmode_stub;

    sa_cl->get_dirtycount = qemu_s390_get_dirtycount_stub;

    sa_cl->get_active = qemu_s390_get_active;



    /* Reason: Can only be instantiated one time (internally) */

    dc->user_creatable = false;

}



static const TypeInfo qemu_s390_stattrib_info = {