Commit 3d937150 authored by John Snow's avatar John Snow
Browse files

qtest/ahci: fix redundant assertion 

Fixes https://bugs.launchpad.net/qemu/+bug/1497711



(!ncq || (ncq && lba48)) is the same as
(!ncq || lba48).

The intention is simply: "If a command is NCQ,
it must also be LBA48."

Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
Message-id: 1442868929-17777-1-git-send-email-jsnow@redhat.com
parent c0b520df

tests/libqos/ahci.c

+1 −1
Original line number Diff line number Diff line
@@ -742,7 +742,7 @@ AHCICommand *ahci_command_create(uint8_t command_name) 
    g_assert(!(props->lba28 && props->lba48));

    g_assert(!(props->read && props->write));

    g_assert(!props->size || props->data);

    g_assert(!props->ncq || (props->ncq && props->lba48));

    g_assert(!props->ncq || props->lba48);



    /* Defaults and book-keeping */

    cmd->props = props;