Commit 3d260cf3 authored by Peter Maydell's avatar Peter Maydell
Browse files

hw/arm/bcm2386: Fix parent type of bcm2386 



The TypeInfo and state struct for bcm2386 disagree about what the
parent class is -- the TypeInfo says it's TYPE_SYS_BUS_DEVICE,
but the BCM2386State struct only defines the parent_obj field
as DeviceState. This would have caused problems if anything
actually tried to treat the object as a TYPE_SYS_BUS_DEVICE.
Fix the TypeInfo to use TYPE_DEVICE as the parent, since we don't
need any of the additional functionality TYPE_SYS_BUS_DEVICE
provides.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarAndrew Baumann <Andrew.Baumann@microsoft.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180313153458.26822-5-peter.maydell@linaro.org
parent bda816f0

hw/arm/bcm2836.c

+1 −1
Original line number Diff line number Diff line
@@ -165,7 +165,7 @@ static void bcm2836_class_init(ObjectClass *oc, void *data) 


static const TypeInfo bcm2836_type_info = {

    .name = TYPE_BCM2836,

    .parent = TYPE_SYS_BUS_DEVICE,

    .parent = TYPE_DEVICE,

    .instance_size = sizeof(BCM2836State),

    .instance_init = bcm2836_init,

    .class_init = bcm2836_class_init,