Commit 3cea94bb authored by Emilio G. Cota's avatar Emilio G. Cota Committed by Richard Henderson
Browse files

cputlb: do not evict empty entries to the vtlb 



Currently we evict an entry to the victim TLB when it doesn't match
the current address. But it could be that there's no match because
the current entry is empty (i.e. all -1's, for instance via tlb_flush).
Do not evict the entry to the vtlb in that case.

This change will help us keep track of the TLB's use rate, which
we'll use to implement a policy for dynamic TLB sizing.

Tested-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Signed-off-by: default avatarEmilio G. Cota <cota@braap.org>
Message-Id: <20190116170114.26802-2-cota@braap.org>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
parent 93f332a5

accel/tcg/cputlb.c

+10 −1
Original line number Diff line number Diff line
@@ -224,6 +224,15 @@ static inline bool tlb_hit_page_anyprot(CPUTLBEntry *tlb_entry, 
           tlb_hit_page(tlb_entry->addr_code, page);

}



/**

 * tlb_entry_is_empty - return true if the entry is not in use

 * @te: pointer to CPUTLBEntry

 */

static inline bool tlb_entry_is_empty(const CPUTLBEntry *te)

{

    return te->addr_read == -1 && te->addr_write == -1 && te->addr_code == -1;

}



/* Called with tlb_c.lock held */

static inline void tlb_flush_entry_locked(CPUTLBEntry *tlb_entry,

                                          target_ulong page)
@@ -591,7 +600,7 @@ void tlb_set_page_with_attrs(CPUState *cpu, target_ulong vaddr, 
     * Only evict the old entry to the victim tlb if it's for a

     * different page; otherwise just overwrite the stale data.

     */

    if (!tlb_hit_page_anyprot(te, vaddr_page)) {

    if (!tlb_hit_page_anyprot(te, vaddr_page) && !tlb_entry_is_empty(te)) {

        unsigned vidx = env->tlb_d[mmu_idx].vindex++ % CPU_VTLB_SIZE;

        CPUTLBEntry *tv = &env->tlb_v_table[mmu_idx][vidx];