Commit 3cb3b154 authored by Alex Williamson's avatar Alex Williamson
Browse files

intel_iommu: Throw hw_error on notify_started 



We don't currently support the MemoryRegionIOMMUOps notifier, so throw
an error should a device require it.

Reviewed-by: default avatarMarcel Apfelbaum <marcel@redhat.com>
Reviewed-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Reviewed-by: default avatarPeter Xu <peterx@redhat.com>
Tested-by: default avatarPeter Xu <peterx@redhat.com>
Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent d22d8956

hw/i386/intel_iommu.c

+12 −0
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ 
#include "exec/address-spaces.h"

#include "intel_iommu_internal.h"

#include "hw/pci/pci.h"

#include "hw/pci/pci_bus.h"



/*#define DEBUG_INTEL_IOMMU*/

#ifdef DEBUG_INTEL_IOMMU
@@ -1871,6 +1872,16 @@ static IOMMUTLBEntry vtd_iommu_translate(MemoryRegion *iommu, hwaddr addr, 
    return ret;

}



static void vtd_iommu_notify_started(MemoryRegion *iommu)

{

    VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu);



    hw_error("Device at bus %s addr %02x.%d requires iommu notifier which "

             "is currently not supported by intel-iommu emulation",

             vtd_as->bus->qbus.name, PCI_SLOT(vtd_as->devfn),

             PCI_FUNC(vtd_as->devfn));

}



static const VMStateDescription vtd_vmstate = {

    .name = "iommu-intel",

    .unmigratable = 1,
@@ -1938,6 +1949,7 @@ static void vtd_init(IntelIOMMUState *s) 
    memset(s->womask, 0, DMAR_REG_SIZE);



    s->iommu_ops.translate = vtd_iommu_translate;

    s->iommu_ops.notify_started = vtd_iommu_notify_started;

    s->root = 0;

    s->root_extended = false;

    s->dmar_enabled = false;