Commit 3ab4c7e9 authored by Kevin Wolf's avatar Kevin Wolf
Browse files

qcow2: Fix error handling for immediate backing file read failure 



Requests could return success even though they failed when bdrv_aio_readv
returned NULL for a backing file read.

Reported-by: default avatarChunqiang Tang <ctang@us.ibm.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent e0d9c6f9

block/qcow2.c

+3 −1
Original line number Diff line number Diff line
@@ -479,8 +479,10 @@ static void qcow2_aio_read_cb(void *opaque, int ret) 
                BLKDBG_EVENT(bs->file, BLKDBG_READ_BACKING_AIO);

                acb->hd_aiocb = bdrv_aio_readv(bs->backing_hd, acb->sector_num,

                                    &acb->hd_qiov, n1, qcow2_aio_read_cb, acb);

                if (acb->hd_aiocb == NULL)

                if (acb->hd_aiocb == NULL) {

                    ret = -EIO;

                    goto done;

                }

            } else {

                ret = qcow2_schedule_bh(qcow2_aio_read_bh, acb);

                if (ret < 0)