Commit 3a688294 authored by Cédric Le Goater's avatar Cédric Le Goater Committed by David Gibson
Browse files

ppc/pnv: check return value of blk_pwrite() 



When updating the PNOR file contents, we should check for a possible
failure of blk_pwrite().

Fixes Coverity issue CID 1412228.

Signed-off-by: default avatarCédric Le Goater <clg@kaod.org>
Message-Id: <20200107171809.15556-2-clg@kaod.org>
Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent b91cad2f

hw/ppc/pnv_pnor.c

+6 −2
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ static uint64_t pnv_pnor_read(void *opaque, hwaddr addr, unsigned size) 
static void pnv_pnor_update(PnvPnor *s, int offset, int size)

{

    int offset_end;

    int ret;



    if (s->blk) {

        return;
@@ -42,8 +43,11 @@ static void pnv_pnor_update(PnvPnor *s, int offset, int size) 
    offset = QEMU_ALIGN_DOWN(offset, BDRV_SECTOR_SIZE);

    offset_end = QEMU_ALIGN_UP(offset_end, BDRV_SECTOR_SIZE);



    blk_pwrite(s->blk, offset, s->storage + offset,

    ret = blk_pwrite(s->blk, offset, s->storage + offset,

                     offset_end - offset, 0);

    if (ret < 0) {

        error_report("Could not update PNOR: %s", strerror(-ret));

    }

}



static void pnv_pnor_write(void *opaque, hwaddr addr, uint64_t data,