Commit 3a4dbe6a authored by Alex Williamson's avatar Alex Williamson
Browse files

vfio-pci: Fix missing unparent of dynamically allocated MemoryRegion 



Commit d8d95814 added explicit object_unparent() calls for
dynamically allocated MemoryRegions.  The VFIOMSIXInfo structure also
contains such a MemoryRegion, covering the mmap'd region of a PCI BAR
above the MSI-X table.  This structure is freed as part of the class
exit function and therefore also needs an explicit object_unparent().
Failing to do this results in random segfaults due to fields within
the structure, often the class pointer, being reclaimed and corrupted
by the time object_finalize_child_property() is called for the object.

Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Cc: qemu-stable@nongnu.org # 2.2
parent 39cb514f

hw/vfio/pci.c

+1 −0
Original line number Diff line number Diff line
@@ -3065,6 +3065,7 @@ static void vfio_put_device(VFIOPCIDevice *vdev) 
{

    g_free(vdev->vbasedev.name);

    if (vdev->msix) {

        object_unparent(OBJECT(&vdev->msix->mmap_mem));

        g_free(vdev->msix);

        vdev->msix = NULL;

    }