Commit 3a37f239 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Peter Maydell
Browse files

hw/input/pxa2xx_keypad: Replace hw_error() by qemu_log_mask() 



hw_error() calls exit(). This a bit overkill when we can log
the accesses as unimplemented or guest error.

When fuzzing the devices, we don't want the whole process to
exit. Replace some hw_error() calls by qemu_log_mask()
(missed in commit 5a0001ec).

Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20200525114123.21317-2-f4bug@amsat.org
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 6d686145

hw/input/pxa2xx_keypad.c

+7 −3
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ 
 */



#include "qemu/osdep.h"

#include "hw/hw.h"

#include "qemu/log.h"

#include "hw/irq.h"

#include "migration/vmstate.h"

#include "hw/arm/pxa.h"
@@ -233,7 +233,9 @@ static uint64_t pxa2xx_keypad_read(void *opaque, hwaddr offset, 
        return s->kpkdi;

        break;

    default:

        hw_error("%s: Bad offset " REG_FMT "\n", __func__, offset);

        qemu_log_mask(LOG_GUEST_ERROR,

                      "%s: Bad read offset 0x%"HWADDR_PRIx"\n",

                      __func__, offset);

    }



    return 0;
@@ -280,7 +282,9 @@ static void pxa2xx_keypad_write(void *opaque, hwaddr offset, 
        break;



    default:

        hw_error("%s: Bad offset " REG_FMT "\n", __func__, offset);

        qemu_log_mask(LOG_GUEST_ERROR,

                      "%s: Bad write offset 0x%"HWADDR_PRIx"\n",

                      __func__, offset);

    }

}