Commit 3a1655fc authored by Michael S. Tsirkin's avatar Michael S. Tsirkin
Browse files

vhost-scsi: init backend features earlier 



As vhost core can use backend_features during init, clear it earlier to
avoid using uninitialized memory.
This use would be harmless since vhost scsi ignores the result
anyway, but initializing earlier will help prevent valgrind errors,
and make scsi and net behave similarly.

Cc: qemu-stable@nongnu.org
Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent b49ae913

hw/scsi/vhost-scsi.c

+1 −1
Original line number Diff line number Diff line
@@ -238,6 +238,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) 
    s->dev.nvqs = VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues;

    s->dev.vqs = g_new(struct vhost_virtqueue, s->dev.nvqs);

    s->dev.vq_index = 0;

    s->dev.backend_features = 0;



    ret = vhost_dev_init(&s->dev, (void *)(uintptr_t)vhostfd,

                         VHOST_BACKEND_TYPE_KERNEL, true);
@@ -246,7 +247,6 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) 
                   strerror(-ret));

        return;

    }

    s->dev.backend_features = 0;



    error_setg(&s->migration_blocker,

            "vhost-scsi does not support migration");