Commit 38d2448a authored by Greg Kurz's avatar Greg Kurz Committed by David Gibson
Browse files

ppc/pnv: Silence missing BMC warning with qtest 



The device introspect test in qtest emits some warnings with the
the pnv machine types during the "nodefaults" phase:

TEST check-qtest-ppc64: tests/qtest/device-introspect-test
qemu-system-ppc64: warning: machine has no BMC device. Use '-device
ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10' to define
one
qemu-system-ppc64: warning: machine has no BMC device. Use '-device
ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10' to define
one
qemu-system-ppc64: warning: machine has no BMC device. Use '-device
ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10' to define
one

This is expected since the pnv machine doesn't create the internal
BMC simulator fallback when "-nodefaults" is passed on the command
line, but these warnings appear in ci logs and confuse people.

Not having a BMC isn't recommended but it is still a supported
configuration, so a straightforward fix is to just silent this
warning when qtest is enabled.

Fixes: 25f3170b ("ppc/pnv: Create BMC devices only when defaults are enabled")
Reported-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Message-Id: <159280903824.485572.831378159272329707.stgit@bahia.lan>
Reviewed-by: default avatarCédric Le Goater <clg@kaod.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 7861e083

hw/ppc/pnv.c

+6 −3
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ 
#include "qemu-common.h"

#include "qemu/units.h"

#include "qapi/error.h"

#include "sysemu/qtest.h"

#include "sysemu/sysemu.h"

#include "sysemu/numa.h"

#include "sysemu/reset.h"
@@ -587,9 +588,11 @@ static void pnv_reset(MachineState *machine) 
    bmc = pnv_bmc_find(&error_fatal);

    if (!pnv->bmc) {

        if (!bmc) {

            if (!qtest_enabled()) {

                warn_report("machine has no BMC device. Use '-device "

                            "ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10' "

                            "to define one");

            }

        } else {

            pnv_bmc_set_pnor(bmc, pnv->pnor);

            pnv->bmc = bmc;