Commit 3894c787 authored May 19, 2014 by Markus Armbruster Committed by Gerd Hoffmann May 21, 2014

char: Explain qmp_chardev_add()'s unusual error handling



Character backend open hasn't been fully converted to the Error API.
Some opens fail without setting an error.  qmp_chardev_add() needs to
detect when that happens, and set a generic error.  Explain that in a
comment, and inline error_is_set() for clarity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

parent 0aff637e

qemu-char.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -3798,7 +3798,13 @@ ChardevReturn qmp_chardev_add(const char id, ChardevBackend *backend,
		break;
		}

		if (chr == NULL && !error_is_set(errp)) {
		/*
		* Character backend open hasn't been fully converted to the Error
		* API. Some opens fail without setting an error. Set a generic
		* error then.
		* TODO full conversion to Error API
		*/
		if (chr == NULL && errp && !*errp) {
		error_setg(errp, "Failed to create chardev");
		}
		if (chr) {