Commit 37e153fe authored by Markus Armbruster's avatar Markus Armbruster Committed by Stefan Hajnoczi
Browse files

blockdev-test: Simplify by using g_assert_cmpstr() 



Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Message-id: 1412261496-24455-5-git-send-email-armbru@redhat.com
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent e319df66

tests/drive_del-test.c

+2 −7
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ 
static void test_drive_without_dev(void)

{

    QDict *response;

    const char *response_return;



    /* Start with an empty drive */

    qtest_start("-drive if=none,id=drive0");
@@ -28,9 +27,7 @@ static void test_drive_without_dev(void) 
                   "   'command-line': 'drive_del drive0'"

                   "}}");

    g_assert(response);

    response_return = qdict_get_try_str(response, "return");

    g_assert(response_return);

    g_assert(strcmp(response_return, "") == 0);

    g_assert_cmpstr(qdict_get_try_str(response, "return"), ==, "");

    QDECREF(response);



    /* Ensure re-adding the drive works - there should be no duplicate ID error
@@ -41,9 +38,7 @@ static void test_drive_without_dev(void) 
                   "   'command-line': 'drive_add 0 if=none,id=drive0'"

                   "}}");

    g_assert(response);

    response_return = qdict_get_try_str(response, "return");

    g_assert(response_return);

    g_assert(strcmp(response_return, "OK\r\n") == 0);

    g_assert_cmpstr(qdict_get_try_str(response, "return"), ==, "OK\r\n");

    QDECREF(response);



    qtest_end();