Commit 3716d590 authored by Jason Wang's avatar Jason Wang Committed by Michael S. Tsirkin
Browse files

pci: introduce a bus master container 



96a8821d ("virtio: unbreak virtio-pci with IOMMU after caching ring
translations") tries to make IOMMU works with virtio memory region
cache, but it requires IOMMU to be created before any virtio
devices. This is sub optimal, fixing this by introduce a bus master
container to make sure address space can be initialized during device
registering, and then we can safely set alias and make
bus_master_enable_region as its subregion during bus master
initialization.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent e45da653

hw/pci/pci.c

+7 −2
Original line number Diff line number Diff line
@@ -88,8 +88,8 @@ static void pci_init_bus_master(PCIDevice *pci_dev) 
                             OBJECT(pci_dev), "bus master",

                             dma_as->root, 0, memory_region_size(dma_as->root));

    memory_region_set_enabled(&pci_dev->bus_master_enable_region, false);

    address_space_init(&pci_dev->bus_master_as,

                       &pci_dev->bus_master_enable_region, pci_dev->name);

    memory_region_add_subregion(&pci_dev->bus_master_container_region, 0,

                                &pci_dev->bus_master_enable_region);

}



static void pcibus_machine_done(Notifier *notifier, void *data)
@@ -995,6 +995,11 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus, 
    pci_dev->devfn = devfn;

    pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev);



    memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev),

                       "bus master container", UINT64_MAX);

    address_space_init(&pci_dev->bus_master_as,

                       &pci_dev->bus_master_container_region, pci_dev->name);



    if (qdev_hotplug) {

        pci_init_bus_master(pci_dev);

    }

include/hw/pci/pci.h

+1 −0
Original line number Diff line number Diff line
@@ -284,6 +284,7 @@ struct PCIDevice { 
    char name[64];

    PCIIORegion io_regions[PCI_NUM_REGIONS];

    AddressSpace bus_master_as;

    MemoryRegion bus_master_container_region;

    MemoryRegion bus_master_enable_region;



    /* do not access the following fields */