Commit 36cccb8c authored by Eduardo Habkost's avatar Eduardo Habkost
Browse files

qdev: Make "hotplugged" property read-only 



The "hotplugged" property is user visible, but it was never meant
to be set by the user. There are probably multiple ways to break
or crash device code by overriding the property. For example, we
recently fixed a crash in rtc_set_memory() related to the
property (commit 26ef65be).

There has been some discussion about making management software
use "hotplugged=on" on migration, to indicate devices that were
hotplugged in the migration source. There were other suggestions
to address this, like including the "hotplugged" field in the
migration stream instead of requiring it to be set explicitly.

Whatever solution we choose in the future, this patch disables
setting "hotplugged" explicitly in the command-line by now,
because the ability to set the property is unused, untested, and
undocumented.

Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170222192647.19690-1-ehabkost@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent dd4d607e

hw/core/qdev.c

+1 −8
Original line number Diff line number Diff line
@@ -1037,13 +1037,6 @@ static bool device_get_hotplugged(Object *obj, Error **err) 
    return dev->hotplugged;

}



static void device_set_hotplugged(Object *obj, bool value, Error **err)

{

    DeviceState *dev = DEVICE(obj);



    dev->hotplugged = value;

}



static void device_initfn(Object *obj)

{

    DeviceState *dev = DEVICE(obj);
@@ -1063,7 +1056,7 @@ static void device_initfn(Object *obj) 
    object_property_add_bool(obj, "hotpluggable",

                             device_get_hotpluggable, NULL, NULL);

    object_property_add_bool(obj, "hotplugged",

                             device_get_hotplugged, device_set_hotplugged,

                             device_get_hotplugged, NULL,

                             &error_abort);



    class = object_get_class(OBJECT(dev));