Commit 35d72602 authored by Max Reitz's avatar Max Reitz
Browse files

block/file-posix: Preallocation for truncate 



By using raw_regular_truncate() in raw_truncate(), we can now easily
support preallocation.

Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Message-id: 20170613202107.10125-9-mreitz@redhat.com
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent d0bc9e5d

block/file-posix.c

+10 −12
Original line number Diff line number Diff line
@@ -1745,12 +1745,6 @@ static int raw_truncate(BlockDriverState *bs, int64_t offset, 
    struct stat st;

    int ret;



    if (prealloc != PREALLOC_MODE_OFF) {

        error_setg(errp, "Unsupported preallocation mode '%s'",

                   PreallocMode_lookup[prealloc]);

        return -ENOTSUP;

    }



    if (fstat(s->fd, &st)) {

        ret = -errno;

        error_setg_errno(errp, -ret, "Failed to fstat() the file");
@@ -1758,12 +1752,16 @@ static int raw_truncate(BlockDriverState *bs, int64_t offset, 
    }



    if (S_ISREG(st.st_mode)) {

        if (ftruncate(s->fd, offset) < 0) {

            ret = -errno;

            error_setg_errno(errp, -ret, "Failed to resize the file");

            return ret;

        return raw_regular_truncate(s->fd, offset, prealloc, errp);

    }

    } else if (S_ISCHR(st.st_mode) || S_ISBLK(st.st_mode)) {



    if (prealloc != PREALLOC_MODE_OFF) {

        error_setg(errp, "Preallocation mode '%s' unsupported for this "

                   "non-regular file", PreallocMode_lookup[prealloc]);

        return -ENOTSUP;

    }



    if (S_ISCHR(st.st_mode) || S_ISBLK(st.st_mode)) {

        if (offset > raw_getlength(bs)) {

            error_setg(errp, "Cannot grow device files");

            return -EINVAL;