Commit 3570d7f6 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Yongbok Kim
Browse files

target-mips: replace break by goto cp0_unimplemented 



this fixes many warnings like:

target/mips/translate.c:6253:13: warning: Value stored to 'rn' is never read
            rn = "invalid sel";
            ^    ~~~~~~~~~~~~~

Reported-by: Clang Static Analyzer
Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: default avatarYongbok Kim <yongbok.kim@imgtec.com>
Signed-off-by: default avatarYongbok Kim <yongbok.kim@imgtec.com>
parent 965447ee

target/mips/translate.c

+44 −44
Original line number Diff line number Diff line
@@ -5458,19 +5458,19 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, int reg, int sel) 
        case 1:

//            gen_helper_mfc0_tracecontrol(arg); /* PDtrace support */

            rn = "TraceControl";

//            break;

            goto cp0_unimplemented;

        case 2:

//            gen_helper_mfc0_tracecontrol2(arg); /* PDtrace support */

            rn = "TraceControl2";

//            break;

            goto cp0_unimplemented;

        case 3:

//            gen_helper_mfc0_usertracedata(arg); /* PDtrace support */

            rn = "UserTraceData";

//            break;

            goto cp0_unimplemented;

        case 4:

//            gen_helper_mfc0_tracebpc(arg); /* PDtrace support */

            rn = "TraceBPC";

//            break;

            goto cp0_unimplemented;

        default:

            goto cp0_unimplemented;

        }
@@ -5496,31 +5496,31 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, int reg, int sel) 
        case 1:

//            gen_helper_mfc0_performance1(arg);

            rn = "Performance1";

//            break;

            goto cp0_unimplemented;

        case 2:

//            gen_helper_mfc0_performance2(arg);

            rn = "Performance2";

//            break;

            goto cp0_unimplemented;

        case 3:

//            gen_helper_mfc0_performance3(arg);

            rn = "Performance3";

//            break;

            goto cp0_unimplemented;

        case 4:

//            gen_helper_mfc0_performance4(arg);

            rn = "Performance4";

//            break;

            goto cp0_unimplemented;

        case 5:

//            gen_helper_mfc0_performance5(arg);

            rn = "Performance5";

//            break;

            goto cp0_unimplemented;

        case 6:

//            gen_helper_mfc0_performance6(arg);

            rn = "Performance6";

//            break;

            goto cp0_unimplemented;

        case 7:

//            gen_helper_mfc0_performance7(arg);

            rn = "Performance7";

//            break;

            goto cp0_unimplemented;

        default:

            goto cp0_unimplemented;

        }
@@ -6116,13 +6116,13 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg, int reg, int sel) 
            rn = "TraceControl";

            /* Stop translation as we may have switched the execution mode */

            ctx->bstate = BS_STOP;

//            break;

            goto cp0_unimplemented;

        case 2:

//            gen_helper_mtc0_tracecontrol2(cpu_env, arg); /* PDtrace support */

            rn = "TraceControl2";

            /* Stop translation as we may have switched the execution mode */

            ctx->bstate = BS_STOP;

//            break;

            goto cp0_unimplemented;

        case 3:

            /* Stop translation as we may have switched the execution mode */

            ctx->bstate = BS_STOP;
@@ -6130,13 +6130,13 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg, int reg, int sel) 
            rn = "UserTraceData";

            /* Stop translation as we may have switched the execution mode */

            ctx->bstate = BS_STOP;

//            break;

            goto cp0_unimplemented;

        case 4:

//            gen_helper_mtc0_tracebpc(cpu_env, arg); /* PDtrace support */

            /* Stop translation as we may have switched the execution mode */

            ctx->bstate = BS_STOP;

            rn = "TraceBPC";

//            break;

            goto cp0_unimplemented;

        default:

            goto cp0_unimplemented;

        }
@@ -6161,31 +6161,31 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg, int reg, int sel) 
        case 1:

//            gen_helper_mtc0_performance1(arg);

            rn = "Performance1";

//            break;

            goto cp0_unimplemented;

        case 2:

//            gen_helper_mtc0_performance2(arg);

            rn = "Performance2";

//            break;

            goto cp0_unimplemented;

        case 3:

//            gen_helper_mtc0_performance3(arg);

            rn = "Performance3";

//            break;

            goto cp0_unimplemented;

        case 4:

//            gen_helper_mtc0_performance4(arg);

            rn = "Performance4";

//            break;

            goto cp0_unimplemented;

        case 5:

//            gen_helper_mtc0_performance5(arg);

            rn = "Performance5";

//            break;

            goto cp0_unimplemented;

        case 6:

//            gen_helper_mtc0_performance6(arg);

            rn = "Performance6";

//            break;

            goto cp0_unimplemented;

        case 7:

//            gen_helper_mtc0_performance7(arg);

            rn = "Performance7";

//            break;

            goto cp0_unimplemented;

        default:

            goto cp0_unimplemented;

        }
@@ -6766,19 +6766,19 @@ static void gen_dmfc0(DisasContext *ctx, TCGv arg, int reg, int sel) 
        case 1:

//            gen_helper_dmfc0_tracecontrol(arg, cpu_env); /* PDtrace support */

            rn = "TraceControl";

//            break;

            goto cp0_unimplemented;

        case 2:

//            gen_helper_dmfc0_tracecontrol2(arg, cpu_env); /* PDtrace support */

            rn = "TraceControl2";

//            break;

            goto cp0_unimplemented;

        case 3:

//            gen_helper_dmfc0_usertracedata(arg, cpu_env); /* PDtrace support */

            rn = "UserTraceData";

//            break;

            goto cp0_unimplemented;

        case 4:

//            gen_helper_dmfc0_tracebpc(arg, cpu_env); /* PDtrace support */

            rn = "TraceBPC";

//            break;

            goto cp0_unimplemented;

        default:

            goto cp0_unimplemented;

        }
@@ -6803,31 +6803,31 @@ static void gen_dmfc0(DisasContext *ctx, TCGv arg, int reg, int sel) 
        case 1:

//            gen_helper_dmfc0_performance1(arg);

            rn = "Performance1";

//            break;

            goto cp0_unimplemented;

        case 2:

//            gen_helper_dmfc0_performance2(arg);

            rn = "Performance2";

//            break;

            goto cp0_unimplemented;

        case 3:

//            gen_helper_dmfc0_performance3(arg);

            rn = "Performance3";

//            break;

            goto cp0_unimplemented;

        case 4:

//            gen_helper_dmfc0_performance4(arg);

            rn = "Performance4";

//            break;

            goto cp0_unimplemented;

        case 5:

//            gen_helper_dmfc0_performance5(arg);

            rn = "Performance5";

//            break;

            goto cp0_unimplemented;

        case 6:

//            gen_helper_dmfc0_performance6(arg);

            rn = "Performance6";

//            break;

            goto cp0_unimplemented;

        case 7:

//            gen_helper_dmfc0_performance7(arg);

            rn = "Performance7";

//            break;

            goto cp0_unimplemented;

        default:

            goto cp0_unimplemented;

        }
@@ -7417,25 +7417,25 @@ static void gen_dmtc0(DisasContext *ctx, TCGv arg, int reg, int sel) 
            /* Stop translation as we may have switched the execution mode */

            ctx->bstate = BS_STOP;

            rn = "TraceControl";

//            break;

            goto cp0_unimplemented;

        case 2:

//            gen_helper_mtc0_tracecontrol2(cpu_env, arg); /* PDtrace support */

            /* Stop translation as we may have switched the execution mode */

            ctx->bstate = BS_STOP;

            rn = "TraceControl2";

//            break;

            goto cp0_unimplemented;

        case 3:

//            gen_helper_mtc0_usertracedata(cpu_env, arg); /* PDtrace support */

            /* Stop translation as we may have switched the execution mode */

            ctx->bstate = BS_STOP;

            rn = "UserTraceData";

//            break;

            goto cp0_unimplemented;

        case 4:

//            gen_helper_mtc0_tracebpc(cpu_env, arg); /* PDtrace support */

            /* Stop translation as we may have switched the execution mode */

            ctx->bstate = BS_STOP;

            rn = "TraceBPC";

//            break;

            goto cp0_unimplemented;

        default:

            goto cp0_unimplemented;

        }
@@ -7460,31 +7460,31 @@ static void gen_dmtc0(DisasContext *ctx, TCGv arg, int reg, int sel) 
        case 1:

//            gen_helper_mtc0_performance1(cpu_env, arg);

            rn = "Performance1";

//            break;

            goto cp0_unimplemented;

        case 2:

//            gen_helper_mtc0_performance2(cpu_env, arg);

            rn = "Performance2";

//            break;

            goto cp0_unimplemented;

        case 3:

//            gen_helper_mtc0_performance3(cpu_env, arg);

            rn = "Performance3";

//            break;

            goto cp0_unimplemented;

        case 4:

//            gen_helper_mtc0_performance4(cpu_env, arg);

            rn = "Performance4";

//            break;

            goto cp0_unimplemented;

        case 5:

//            gen_helper_mtc0_performance5(cpu_env, arg);

            rn = "Performance5";

//            break;

            goto cp0_unimplemented;

        case 6:

//            gen_helper_mtc0_performance6(cpu_env, arg);

            rn = "Performance6";

//            break;

            goto cp0_unimplemented;

        case 7:

//            gen_helper_mtc0_performance7(cpu_env, arg);

            rn = "Performance7";

//            break;

            goto cp0_unimplemented;

        default:

            goto cp0_unimplemented;

        }