Commit 3541b084 authored by Daniel P. Berrangé's avatar Daniel P. Berrangé Committed by Gerd Hoffmann
Browse files

ui: avoid pointless VNC updates if framebuffer isn't dirty 



The vnc_update_client() method checks the 'has_dirty' flag to see if there are
dirty regions that are pending to send to the client. Regardless of this flag,
if a forced update is requested, updates must be sent. For unknown reasons
though, the code also tries to sent updates if audio capture is enabled. This
makes no sense as audio capture state does not impact framebuffer contents, so
this check is removed.

Signed-off-by: default avatarDaniel P. Berrange <berrange@redhat.com>
Reviewed-by: default avatarDarren Kenny <darren.kenny@oracle.com>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-5-berrange@redhat.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent b939eb89

ui/vnc.c

+1 −1
Original line number Diff line number Diff line
@@ -984,7 +984,7 @@ static int vnc_update_client(VncState *vs, int has_dirty) 
        return 0;

    }



    if (!vs->has_dirty && !vs->audio_cap && !vs->force_update) {

    if (!vs->has_dirty && !vs->force_update) {

        return 0;

    }