Commit 34f405ae authored by Marcel Apfelbaum's avatar Marcel Apfelbaum Committed by Markus Armbruster
Browse files

vl.c: Fix regression in machine error message 



Commit e1ce0c3c (vl.c: fix regression when reading machine type
from config file) fixed the error message when the machine type
was supplied inside the config file. However now the option name
is not displayed correctly if the error happens when the machine
is specified at command line.

Running
    ./x86_64-softmmu/qemu-system-x86_64 -M q35-1.5 -redir tcp:8022::22
will result in the error message:
    qemu-system-x86_64: -redir tcp:8022::22: unsupported machine type
    Use -machine help to list supported machines

Fixed it by restoring the error location and also extracted the code
dealing with machine options into a separate function.

Reported-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarLaszlo Ersek <lersek@redhat.com>
Signed-off-by: default avatarMarcel Apfelbaum <marcel@redhat.com>
Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Message-Id: <1455303747-19776-2-git-send-email-ehabkost@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent dd5e38b1

vl.c

+26 −11
Original line number Diff line number Diff line
@@ -2762,6 +2762,31 @@ static const QEMUOption *lookup_opt(int argc, char **argv, 
    return popt;

}



static void set_machine_options(MachineClass **machine_class)

{

    const char *optarg;

    QemuOpts *opts;

    Location loc;



    loc_push_none(&loc);



    opts = qemu_get_machine_opts();

    qemu_opts_loc_restore(opts);



    optarg = qemu_opt_get(opts, "type");

    if (optarg) {

        *machine_class = machine_parse(optarg);

    }



    if (*machine_class == NULL) {

        error_report("No machine specified, and there is no default");

        error_printf("Use -machine help to list supported machines\n");

        exit(1);

    }



    loc_pop(&loc);

}



static int machine_set_property(void *opaque,

                                const char *name, const char *value,

                                Error **errp)
@@ -3986,17 +4011,7 @@ int main(int argc, char **argv, char **envp) 


    replay_configure(icount_opts);



    opts = qemu_get_machine_opts();

    optarg = qemu_opt_get(opts, "type");

    if (optarg) {

        machine_class = machine_parse(optarg);

    }



    if (machine_class == NULL) {

        error_report("No machine specified, and there is no default");

        error_printf("Use -machine help to list supported machines\n");

        exit(1);

    }

    set_machine_options(&machine_class);



    set_memory_options(&ram_slots, &maxram_size, machine_class);